INFRA-388 Converting smartmon into python and adding mock tests #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougszumski
reviewed
Oct 25, 2024
technowhizz
changed the title
technowhizz
force-pushed
the
smartmon-py
branch
from
93fd068 to
146b26c
Compare
dougszumski
reviewed
Jan 24, 2025
|
|
||
| def create_mock_device_from_json(self, device_info, if_attributes=None): | ||
| """ | ||
| Given a 'device_info' dict and optional 'if_attributes', build |
There was a problem hiding this comment.
Can you create an actual pySmart device object here from the file output?
Eg. https://github.com/truenas/py-SMART/blob/master/tests/test_device.py#L43
There was a problem hiding this comment.
So I gave this a shot but it turns out that it also requires a mock for smartctl and this made it a lot more complicated to just use a pySmart device. I think it makes more sense to mock it here
…re for better error reporting
technowhizz
force-pushed
the
smartmon-py
branch
from
c0da0ea to
e0bae71
Compare
dougszumski
reviewed
Apr 11, 2025
| for metric in sorted(metrics): | ||
| metric_name = metric.split("{")[0] | ||
| if metric_name != last_metric: | ||
| output.append(f"# HELP smartmon_{metric_name} SMART metric {metric_name}") |
There was a problem hiding this comment.
Please can you switch to the Prometheus library here? It is a slight change that it will write directly to a file for scraping. The advantage is that it handles all the metric formatting. A rough example:
from prometheus_client import CollectorRegistry, Gauge, write_to_textfile
metric_registry = CollectorRegistry()
metric_output_path = os.environ['SMART_METRIC_OUTPUT_PATH'])
for metric in metrics:
g = Gauge(metric_name, 'some help stirng', registry=registry)
g.set(metric_value)
write_to_textfile(metric_output_path, registry)
https://prometheus.github.io/client_python/exporting/textfile/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.